BUG: array_api.argsort(descending=True) respects relative sort order
#20788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a test. Note that it should be fairly easy to add reverse sorts at some point, the big problem is adding a more flexible way to add sort types, they are currently limited by the basic array struct. |
|
|
Thanks @honno . |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jan 12, 2022
numpy#20788) * BUG: `array_api.argsort(descending=True)` respects relative order * Regression test for stable descending `array_api.argsort()`
array_api.argsort(descending=True) respects relative sort orderarray_api.argsort(descending=True) respects relative sort order
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jan 12, 2022
numpy#20788) * BUG: `array_api.argsort(descending=True)` respects relative order * Regression test for stable descending `array_api.argsort()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20778. Tested in array-api-tests , specifically https://github.com/data-apis/array-api-tests/blob/314e1be134b96e2d6c40ee87492d807838292195/array_api_tests/test_sorting_functions.py#L41