BUILD: remove condition on upload step #21035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
reviewed
Feb 11, 2022
.github/workflows/wheels.yml
Outdated
| @@ -152,7 +152,7 @@ jobs: | |||
| echo "ANACONDA_UPLOAD=false" >> $GITHUB_ENV | |||
| fi | |||
| - name: Upload wheels | |||
| if: ${{ env.TOKEN }} | |||
| # if: ${{ env.TOKEN }} # doesn't work | |||
There was a problem hiding this comment.
Would it make more sense to just fuse the two steps Setup Upload Variables and Upload Wheels together?
|
self-merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition for the "Upload wheels" step is not working, see this scheduled build which should have uploaded (the "Set Upload Variables" step prints "scheduled or dispatched event", so the environment variables are set).
Removing the condition will allow the step to silently skip since there is a check that
$TOKENis set.