BUG: (loadtxt) Ignore last empty field when delimiter=None
#21054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
reviewed
Feb 14, 2022
| f"1 2{ws}30\n\n{ws}\n" | ||
| f"4 5 60{ws}\n {ws} \n" | ||
| f"7 8 {ws} 90\n # comment\n" | ||
| f"3 2 1" |
There was a problem hiding this comment.
What about adding a regular ' ' space to the tests too?
There was a problem hiding this comment.
Sounds good, added it to the templating parametrization.
When the delimiter is None and we are splitting on whitespace, a final empty field is always ignored to match the behaviour of pythons split: `" 1 ".split()`. Closes numpygh-21052
41078e2 to
67bb936
Compare
|
Build error with breathe not related to this PR, probably related to a new breathe version v4.33.0 and this bugfix for that release in v4.33.1 |
|
Thanks @seberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the delimiter is None and we are splitting on whitespace,
a final empty field is always ignored to match the behaviour
of pythons split:
" 1 ".split().Closes gh-21052
Opted for a slightly different variant of cleaning this up in hindsight. There is a small thing that the "skip leading whitespace" may need some thought if we were to make it public. But I think using the special "delimiter is whitspace" state here, helps with ensuring that things won't go weird.
This includes my "move to cpp" commit, I assume that will be merged so I don't need to worry about it here.