-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
BLD: move cibuildwheel configuration to pyproject.toml
#21128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If having the configuration in |
02e5bc9
to
ed83d41
Compare
This PR makes sense. How sure are you that the new code is equivalent to the old? Can we somehow compare the number of tests run or some other parameter that would give us confidence that this is correct? |
This allows to share the configuration between GitHub Actions and Travis-CI. This also allows to easily run cibuildwheel locally to debug build issues when they arise.
ed83d41
to
3826415
Compare
I will check number of tests and environment for all wheels. |
@mattip, a deeper look into what you asked for showed some diffs:
|
cp39-win32 & cp310-win32 are in fact showing the same tests results. It was only for cp38-win32 because it seems that GHA runners do not all offer the same level of SIMD support and thus, some tests were skipped on cp38-win32 in this PR. |
That was an oversight in the previous cibuildwheel work. Thanks for checking. Since we will merge this, no backport fix is needed, right? |
Right, just asking if you wanted to split this in 2 to split the |
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Thanks @mayeut |
This allows to share the configuration between GitHub Actions and Travis-CI.
This also allows to easily run cibuildwheel locally to debug build issues when they arise.