ENH: Introduce numpy.core.setup_common.NPY_CXX_FLAGS #21306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fde2ec to
9e583c2
Compare
mattip
reviewed
Apr 7, 2022
9e583c2 to
0c8b62b
Compare
mattip
reviewed
Apr 7, 2022
| '-D__STDC_VERSION__=0', # for compatibility with C headers | ||
| '-fno-exceptions', # no exception support | ||
| '-fno-rtti'] # no runtime type information | ||
|
|
There was a problem hiding this comment.
I wonder if we should document these flags in numpy/doc/source/user/building.rst as "the set of c++ features we support", xref #21299
There was a problem hiding this comment.
Yeah, that would make sense.
Group all C++ flags in one location. This avoids redundancy and makes sure we test the flags we use, and use the flags we test. Fix numpy#21302
0c8b62b to
c91a7d0
Compare
|
Thanks @serge-sans-paille |
4 tasks
|
@charris did you plan on backporting this to 1.22.4? That seems like a good idea, given that it's broken in 1.22.3 |
|
I will now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group all C++ flags in one location.
This avoids redundancy and makes sure we test the flags we use, and use the
flags we test.
Fix #21302