BENCH: Add benchmarks targeted at small arrays #21463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rather than create new benchmarks, could we extend the current ones with smaller arrays? |
bae9511 to
44a7e37
Compare
Sure. I moved them into the existing benchmarks. Let me know if I should move them to some other location or if some of tests are added are redundant. @mattip |
mattip
reviewed
May 10, 2022
benchmarks/benchmarks/bench_core.py
Outdated
|
|
||
| def time_mean_axis(self): | ||
| np.mean(self.array_4_5, axis=1) | ||
|
|
||
|
|
There was a problem hiding this comment.
It turns out we do not bencmark np.mean. I think this belongs in bench_functions_base.py, since that is where median, percentile and other numeric functions are checked.
mattip
reviewed
May 10, 2022
mattip
reviewed
May 10, 2022
mattip
reviewed
May 10, 2022
44a7e37 to
2534a7c
Compare
|
Thanks @eendebakpt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a benchmark file specifically targeted at small arrays and scalars.
The goal is to benchmark the overhead of the various numpy methods. For benchmarks with large arrays (e.g. size > 1e6) the overhead is small compared to the actual computation, but for small arrays it is not.