MAINT: fix up use of NPY_NO_DEPRECATED_API usage in f2py
#21786
Conversation
This was giving a lot of warnings like:
numpy/f2py/src/fortranobject.h:9: warning: "NPY_NO_DEPRECATED_API" redefined
when building SciPy. In general, this is generated code which is
included in the build of other projects which may have already set this
macro - so only set it if it is not yet set.
The other change is to set it to the current numpy version, like is done
everywhere else in numpy, rather than to a fixed 1.7 version.
This will ensure that if new deprecations happen, f2py gets updated for
them.
|
I did something like this years ago, but there was a problem where, IIRC, f2py was switching data pointers in an array and that wasn't possible with the new interface functions. Maybe that has been fixed? |
That must have been fixed, because things work in |
Or maybe it this change doesn't affect all the generated C code? In any case, this seems to work. |
Ah, thanks for the link. I hadn't noticed that the API usage was fixed. That removes a small task that has been in the back of my mind for many years. Good riddance :) |
|
Thanks Ralf. |
This was giving a lot of warnings like:
when building SciPy. In general, this is generated code which is included in the build of other projects which may have already set this macro - so only set it if it is not yet set.
The other change is to set it to the current numpy version, like is done everywhere else in numpy, rather than to a fixed 1.7 version. This will ensure that if new deprecations happen, f2py gets updated for them.
This came in with gh-19388 recently (not present in the 1.23.x branch).