BUG: Fix discovered MachAr (still used within valgrind) #21815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the missing attributes. I tested the warning and fix on valgrind itself. These attributes were added in numpygh-18536 but the fallback path was not checked there. Replaces numpygh-21813, although something more like it may make sense if it allows us to just delete MachAr completely.
|
Thanks Sebastian. |
|
I suspect we should backport this, to close gh-21827. I would not worry much about backporting for valgrind only, but msys2 running into issue (maybe due to a h5py change) warrents a backport probably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the missing attributes. I tested the warning and fix
on valgrind itself.
These attributes were added in gh-18536 but the fallback path was
not checked there.
Replaces gh-21813, although something more like it may make sense
if it allows us to just delete MachAr completely.