Skip to content

Add Dependabot configuration for GitHub Actions updates #22514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Nov 2, 2022

Add a Dependabot configuration that checks once a week if the GitHub Actions are still using the latest version. If not, it opens a PR to update them.

It will actually open very few PRs, since we only have major versions specified (like v3), so only on a major v4 release it will update and open a PR.

See Keeping your actions up to date with Dependabot.

Add a Dependabot configuration that checks once a week if the GitHub Actions are still using the latest version. If not, it opens a PR to update them.

It will actually open very few PRs, since we only have major versions specified (like v3), so only on a major v4 release it will update and open a PR.

See https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot
EwoutH added a commit to EwoutH/numpy that referenced this pull request Nov 2, 2022
By removing the exact minor and patch version of the cibuildwheel action, it will always use the latest minor/patch version. For cirrus, it will use the latest version even for new major versions.

This ensures the latest Python versions are always used to build wheels.

Major version updates will be handled by numpy#22514 for GitHub Actions.
@charris
Copy link
Member

charris commented Nov 2, 2022

This looks fine. What are the advantages/disadvantages of keeping GitHub Actions up to date? Can an update break things?

@EwoutH
Copy link
Contributor Author

EwoutH commented Nov 3, 2022

Updates can certainly break things, but not updating will almost always also break things at some point.

This way for each action that can be updated, a PR will be openend. So it will update in a controlled manner, and when the PR is openend the workflows will run so you can see if things break or not.

@charris
Copy link
Member

charris commented Nov 3, 2022

Note that we removed dependabot in #20268 because it was spamming all the NumPy forks. See #18977 for an explanation of the problem. AFAICT with a short look, that problem isn't fixed.

@EwoutH
Copy link
Contributor Author

EwoutH commented Nov 3, 2022

That's a valid concern, especially for such a large project like NumPy.

They're working on disabling it on forks, so we can also wait a bit to see where that leads to.

We're actively working on this and a permanent fix should land in the next couple of weeks. We'll share more around the time we''re ready to roll this out

Another option would be using a GitHub Actions workflows with an conditional statement that it only runs on this repository (numpy/numpy).

@rgommers
Copy link
Member

rgommers commented Nov 4, 2022

I am a hard -1 on adding back Dependabot, their behavior has been terrible. Sorry @EwoutH. There's also no real need for auto-updating here as far as I can tell. I cannot remember a case where we actually needed this. Maybe there have been one or two, not quite sure, but it doesn't seem like an actual problem that we're having that needs solving.

@rgommers rgommers closed this Nov 4, 2022
@EwoutH
Copy link
Contributor Author

EwoutH commented Nov 4, 2022

No worries, I heard the stories by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants