Skip to content

DOC #22266 Add examples for diag_indices_from() #22559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

richierocks
Copy link
Contributor

Adds examples to the documentation for diag_indices_from(), as requested in #22266.

Written as part of the PyData 2022 sprint.

@WarrenWeckesser
Copy link
Member

WarrenWeckesser commented Nov 8, 2022

Thanks @richierocks. The NumPy docstring standard specifies that the Examples section is the last section of the docstring. In this case, it should be after the Notes section.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of applying a few minor fixups and had to merge with main to get CI running. This LGTM - I'll put this in assuming CI is green. Thanks @richierocks

@mattip mattip merged commit 2289292 into numpy:main Jan 26, 2023
@mattip
Copy link
Member

mattip commented Jan 26, 2023

Thanks @richierocks, @rossbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants