BLD: fix build warning about backtrace implicit definition
#22613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exact warning was:
```
[1/3] Compiling C object numpy/core/_multi...nux-gnu.so.p/src_multiarray_temp_elide.c.o
../numpy/core/src/multiarray/temp_elide.c: In function 'check_callers':
../numpy/core/src/multiarray/temp_elide.c:154:13: warning: implicit declaration of function 'backtrace' [-Wimplicit-function-declaration]
154 | nptrs = backtrace(buffer, NPY_MAX_STACKSIZE);
| ^~~~~~~~~
```
charris
approved these changes
Nov 17, 2022
|
Hmm, re-running CI. The Emscripten failure seemed like a connection issue, the AVX512 failure looked real though. |
seberg
reviewed
Nov 17, 2022
| @@ -7,6 +7,10 @@ | |||
| #include "npy_config.h" | |||
| #include "numpy/arrayobject.h" | |||
|
|
|||
| #if defined HAVE_BACKTRACE | |||
| #include <execinfo.h> | |||
| #endif | |||
There was a problem hiding this comment.
In other places, we use:
#if defined HAVE_EXECINFO_H
#include <execinfo.h>
#elif defined HAVE_LIBUNWIND_H
#include <libunwind.h>
#endif
See gh-22152. That might be what is needed for Emscripten (or at least for something else).
|
Overlooked something, I'll close this for now - the code may be fine and the hiccup in my new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exact warning was: