TST: tests/core/test_multiarray:TestArg{Min,Max}: stray np.repeat
#22891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test does `a.repeat(129)` and discards the result: >>> a.repeat(129) >>> np.argmin(a)
|
Humm, I really thought we return the first occurance!? Does anyone remember, I guess this behavior now exists for the whole 1.23.x series in any case. |
|
We do return the first occurrence. In the updated tests, the first occurrence of the extreme value in the original array is at index 1, so in the repeated array the first occurrence of the extreme value is at index 129. |
|
Right, was repeating the triplet instead of individual elements in my head. Thanks Evgeni. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a test, which
a.repeat(129)and discards the result, so that the output of the first and the third lines are identical:The test was introduced in 762538c, a part of #20846.
So this PR makes an assumption that the intention of the test was to actually run argmin on a repeated array, and modifies the test accordingly.