DOC: Fix matplotlib error in documentation #23212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted by Kyle Sunden, this was deprecated and has been removed, using the method is the correct way of doing it in newer matplotlib. Closes numpygh-23209 Co-authored-by: Kyle Sunden <ksunden@users.noreply.github.com>
|
Self-merging. The change is trivial, unbreaks CI and I checked that the output looks the same as before. |
Yes, it was a quick fix for maintenance, but I thought it needed a better fix going forward. I'll backport this just because it is likely someone will use the latest matplotlib despite the pin. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Feb 16, 2023
Backport of numpy#23212 As noted by Kyle Sunden, this was deprecated and has been removed, using the method is the correct way of doing it in newer matplotlib. Closes numpygh-23209 Co-authored-by: Kyle Sunden <ksunden@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by Kyle Sunden, this was deprecated and has been removed, using the method is the correct way of doing it in newer matplotlib.
Closes gh-23209
Co-authored-by: Kyle Sunden ksunden@users.noreply.github.com
Lets unbreak CI. @charris it was intentional that you put the other fixup into the maintenance branch?