Skip to content

BLD: improve handling of CBLAS, add -Duse-ilp64 build option #23984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2023
Merged

BLD: improve handling of CBLAS, add -Duse-ilp64 build option #23984

merged 2 commits into from
Jun 26, 2023

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Jun 19, 2023 •
edited
Loading

In a conda env:

Run-time dependency openblas found: YES 0.3.23
Checking if "CBLAS" with dependency openblas: links: YES

On Arch Linux before the just-updated 0.23.23-2 build that included CBLAS and LAPACK in the openblas package (see #23909 (comment)):

$ python -m build --wheel
...
Run-time dependency openblas found: YES
Checking if "CBLAS" with dependency openblas: links: NO
Run-time dependency cblas found: YES 3.11.0
...
$ cd dist
$ unzip numpy-2.0.0.dev0-cp311-cp311-linux_x86_64.whl
$ ldd numpy/core/_multiarray_umath.cpython-311-x86_64-linux-gnu.so
        linux-vdso.so.1 (0x00007fff59235000)
        libopenblas.so.0 => /usr/lib/libopenblas.so.0 (0x00007f5cb4b08000)
        libcblas.so.3 => /usr/lib/libcblas.so.3 (0x00007f5cb62b3000)
        libm.so.6 => /usr/lib/libm.so.6 (0x00007f5cb4a1b000)
        libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x00007f5cb628e000)
        libc.so.6 => /usr/lib/libc.so.6 (0x00007f5cb4831000)
        libgomp.so.1 => /usr/lib/libgomp.so.1 (0x00007f5cb623d000)
        /usr/lib64/ld-linux-x86-64.so.2 (0x00007f5cb62f2000)

Closes gh-23909

@rgommers
BLD: improve handling of CBLAS, add -Duse-ilp64 build option
b4dfbe8 
In a conda env:
```
Run-time dependency openblas found: YES 0.3.23
Checking if "CBLAS" with dependency openblas: links: YES
```

On Arch Linux before the just-updated 0.23.23-2 build that included
CBLAS and LAPACK in the `openblas` package (see numpygh-23909):
```
$ python -m build --wheel
...
Run-time dependency openblas found: YES
Checking if "CBLAS" with dependency openblas: links: NO
Run-time dependency cblas found: YES 3.11.0
...

$ ldd numpy/core/_multiarray_umath.cpython-311-x86_64-linux-gnu.so
        linux-vdso.so.1 (0x00007fff59235000)
        libopenblas.so.0 => /usr/lib/libopenblas.so.0 (0x00007f5cb4b08000)
        libcblas.so.3 => /usr/lib/libcblas.so.3 (0x00007f5cb62b3000)
        libm.so.6 => /usr/lib/libm.so.6 (0x00007f5cb4a1b000)
        libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x00007f5cb628e000)
        libc.so.6 => /usr/lib/libc.so.6 (0x00007f5cb4831000)
        libgomp.so.1 => /usr/lib/libgomp.so.1 (0x00007f5cb623d000)
        /usr/lib64/ld-linux-x86-64.so.2 (0x00007f5cb62f2000)

```

Closes numpygh-23909
@rgommers rgommers added 36 - Build Build related PR Meson Items related to the introduction of Meson as the new build system for NumPy labels Jun 19, 2023
@rgommers rgommers marked this pull request as draft June 19, 2023 06:31
This was referenced Jun 19, 2023
Closed
Closed
@refparo
Copy link

refparo commented Jun 24, 2023

I can confirm that pip install-ing this works on Arch Linux with Python 3.12.0b2.

@rgommers rgommers marked this pull request as ready for review June 24, 2023 09:22
@rgommers rgommers added this to the 2.0.0 release milestone Jun 24, 2023
@rgommers
Copy link
Member Author

Thanks @refparo. This should be good to go then, marked as ready for review.

seberg
seberg approved these changes Jun 24, 2023
View reviewed changes
Copy link
Member

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, rest looks fine to me.

@rgommers @seberg
BLD: apply review comment about NPY_USE_BLAS_ILP64
7ed6f0e 
[skip circle] [skip cirrus]

Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
@seberg seberg merged commit 32ba5eb into numpy:main Jun 26, 2023
@seberg
Copy link
Member

seberg commented Jun 26, 2023

Nice, thanks Ralf.

@rgommers rgommers deleted the meson-blas-improvements branch June 26, 2023 12:25
@seberg seberg mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberg seberg seberg approved these changes

Assignees
No one assigned
Labels
36 - Build Build related PR Meson Items related to the introduction of Meson as the new build system for NumPy
Projects
None yet
Milestone
2.0.0 release
Development

Successfully merging this pull request may close these issues.

BLD: undefined symbol: cblas_sgemm when building with meson with pip install
3 participants
@rgommers @refparo @seberg