BUG: random: Fix generation of nan by dirichlet. #24220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't call the C function random_beta() with both parameters `a` and `b` set to 0. In the case where this would occur, we know that the remaining values in the random vector being generated must be 0, so can break out of the loop early. After this change, when alpha is all zero, the random variates will also be all zero. Closes numpygh-24210.
0b1d70e to
c27678e
Compare
|
I updated the code so now, instead of generating an error, all zeros are returned when |
|
Let's give this a shot. Thanks Warren. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't call the C function random_beta() with both parameters
aandbset to 0. In the case where this would occur, we know that the remaining values in the random vector being generated must be 0, so can break out of the loop early.After this change, when alpha is all zero, the random variates will also be all zero.
Closes gh-24210.