Skip to content

CI: apt update before apt install on cirrus #24303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

CI: apt update before apt install on cirrus #24303

merged 1 commit into from
Jul 31, 2023

Conversation

ngoldbaum
Copy link
Member

This should hopefully fix the CI failures on cirrus seen on #24154.

@charris charris added 03 - Maintenance 09 - Backport-Candidate PRs tagged should be backported labels Jul 31, 2023
@charris charris added this to the 1.26.0 release milestone Jul 31, 2023
seberg
seberg approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM and certainly can't hurt. Part of me wonders if some of the other recent cirrus changes are involved.

@ngoldbaum ngoldbaum mentioned this pull request Jul 31, 2023
Merged
@seberg seberg merged commit 1988506 into numpy:main Jul 31, 2023
@seberg
Copy link
Member

seberg commented Jul 31, 2023

Nvm, let's just try this. I think the cirrus tests default to not run now, so not sure it would show up here anyway (and it wouldn't on the PRs it currently does after rebase). But it probably is the right thing to do and we need it.

Ping @andyfaff just in case I am misinterpreting things.

@andyfaff
Copy link
Member

The cirrus wheel builds don't happen automatically now, they're only once a week, or when requested.
The recent cirrus configuration changes weren't related to the actual wheel build run itself, just its triggering. A wheel build just happened for 1.26, so the wheel configuration can't be all that messed up. An apt update is usually a good idea anyway.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Aug 3, 2023
@charris charris removed this from the 1.26.0 release milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberg seberg seberg approved these changes

Assignees
No one assigned
Labels
03 - Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ngoldbaum @seberg @andyfaff @charris