BLD: allow specifying the long double format to avoid the runtime check #24414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filipe Laíns <lains@riseup.net>
5ae1828 to
582a402
Compare
|
To confirm the values for hardcoding when cross-compiling from x86 to 64-bit ARM: |
|
Yes definitely, that's a good thing to do. I forgot to mark it for backporting, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds towards the goal of being able to cross-build NumPy without requiring code
execution on the target environment, or an emulator thereof.
With this patch, setting the
longdouble_formatkey onpropertiessection of theMeson cross file, will skip the runtime check.
Example:
It may be possible to rewrite the check to entirely skip the need of running code on the
target at build time, but I haven't looked into that at this point. That would be a possible
future improvement.