MAINT: revert adding distutils and array_api to np.__all__
#24427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has turned out to be too disruptive; `from numpy import *` has to remain warning-free and these two modules emit a warning on import rather than when they're actually used. `array_api` we have to decide on for 2.0 (either remove the experimental warning or remove it), I'll open a separate issue to follow up on that.
|
Heh, yeah... these definitely can't be here, thanks for the quick fix! I will retrigger the nightlies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has turned out to be too disruptive;
from numpy import *has to remain warning-free and these two modules emit a warning on import rather than when they're actually used.array_apiwe have to decide on for 2.0 (either remove the experimental warning or remove it), I'll open a separate issue to follow up on that, because it may take a bit of time to decide on that one.For issues this caused, see for example:
This was my fault by the way - I suggested including these modules in
__all__and__dir__in gh-24357. All the other changes there are still fine.Cc @pllim, @mroeschke, @mtsokol for info.