MAINT: Remove deprecated functions [NEP 52] #24477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bae5415 to
996dfbd
Compare
rgommers
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
LGTM, thanks @mtsokol.
The two deprecated functions are logical to remove, and nbytes is too - (it's not in the docs, and there are few usages that can be found with code search, and none in any of the regular PyData libraries).
I'll leave this open for some time as usual, since they're removals, but this seems uncontroversial.
Thanks for the more byte-sized PRs, nice for reviewers.
996dfbd to
27a8806
Compare
|
I added changelog file and "expired attributes" dict entries. |
b51dad2 to
34ee134
Compare
34ee134 to
451e80a
Compare
|
No more comments for a week, and this is pretty straightforward - in it goes. I'll note that the |
1 task
This was referenced Sep 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #23999
Hi @rgommers @ngoldbaum,
This PR removes:
find_common_typefunction that was deprecated in1.25.0in Februaryround_function that was also deprecated in1.25.0nbytesdictionaryOther closely related libraries aren't affected.