API: Update lib.type_check namespace
#24537
Merged
+22
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
c538d79 to
2f11e49
Compare
2f11e49 to
cb60e03
Compare
Sure! Rebased. |
|
This one will need another rebase. |
cb60e03 to
4e1f7cf
Compare
Done! |
rgommers
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Thanks Mateusz, this LGTM now.
After the slight hiccup with function_base, I verified manually which function names are removed from the numpy.lib namespace with this PR. Those are:
['isrealobj',
'imag',
'iscomplexobj',
'isreal',
'real_if_close',
'common_type',
'iscomplex',
'real',
'typename',
'mintypecode',
'nan_to_num']
All of these are available in the main namespace and nothing looks like it should stay in numpy.lib, so this all looks fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue #24507
Hi @rgommers @ngoldbaum,
This PR moves
lib.type_checkmodule to a private file and ensures that its public methods are only available through the main namespace. There are no additional functions available from a local namespace.