API: Readd add_docstring and add_newdoc to np.lib
#24564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
reviewed
Aug 28, 2023
97df2d8 to
6658e74
Compare
rgommers
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Thanks for the quick fix @mtsokol. These removals from numpy.lib were unintentional, so in this goes. We can revisit the rest later. add_docstring looks more questionable and is used less than add_newdoc, so I expect we'd clean up at least that one later on.
|
Thanks @mtsokol! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue #24507
Hi @rgommers,
Reverts a change introduced in #24538.
As agreed in the main namespace design,
add_docstringandadd_newdocshould stay innp.liband be available only from that namespace. These two were unnecessarily removed from there in #24538. (np.libnamespace refactor PR is still TBD, but this needs to be merged to fix SciPy builds)