I see DummyArray is included in the public stride_tricks namespace as well. Searching, it does seem to have some downstream usage. However, its implementation is literally:

class DummyArray:
    """Dummy object that just exists to hang __array_interface__ dictionaries                                                                                         
    and possibly keep alive a reference to a base array.                                                                                                              
    """

    def __init__(self, interface, base=None):
        self.__array_interface__ = interface
        self.base = base

So IMO, we should make it private and add a note to the migration guide that downstream projects who need it should just copy/paste it into their source tree. There's no need to expand the docstrings or make public something so trivial to implement.

So IMO, we should make it private and add a note to the migration guide that downstream projects who need it should just copy/paste it into their source tree. There's no need to expand the docstrings or make public something so trivial to implement.

That makes sense to me. In the github search engine it shows only 13 hits, so I removed it from the public np.lib.stride_tricks namespace.

Ah yeah, it does look like there are quite a few downstream usages.

That link doesn't show me anything. The numpy.lib.stride_tricks namespace is still present after this PR gets merged. Can you elaborate?

That link doesn't show me anything. The numpy.lib.stride_tricks namespace is still present after this PR gets merged. Can you elaborate?

Oops, sorry, you're right, they're all usages of as_strided and sliding_window_view, never mind.

OK, in that case, in it goes.