Skip to content

TYP: Add the missing casting keyword to np.clip #24611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Sep 1, 2023

Closes #24391

Quite straightforward: this PR adds annotations for the previously missing casting keyword to the np.clip function.

@BvB93 BvB93 added the 09 - Backport-Candidate PRs tagged should be backported label Sep 1, 2023
@charris charris merged commit 52556d8 into numpy:main Sep 1, 2023
@charris
Copy link
Member

charris commented Sep 1, 2023

Thanks Bas.

@BvB93 BvB93 deleted the clip branch September 1, 2023 14:17
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Sep 1, 2023
@charris charris changed the title TYP: Add the missing casting keyword to np.clip TYP: Add the missing casting keyword to np.clip Sep 1, 2023
charris added a commit to charris/numpy that referenced this pull request Sep 1, 2023
The line
```
    extobj: list[Any] = ...,
```
was cut when backporting numpy#24611. We want to keep it in 1.26.x.
charris added a commit to charris/numpy that referenced this pull request Nov 11, 2023
The line
```
    extobj: list[Any] = ...,
```
was cut when backporting numpy#24611. We want to keep it in 1.26.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: static typing of numpy.clip seems to be missing some kwargs
2 participants