Skip to content

TST: Skip f2py compilation tests on 3.12 #24751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

TST: Skip f2py compilation tests on 3.12 #24751

wants to merge 1 commit into from

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Sep 19, 2023

This should have been done as part of #24532 which mentioned (correctly) that the CI tests haven't been updated for meson yet.

Should actually be fixed in the next release but just in case anyone needs the patch (e.g.) #24750

@HaoZeke
Copy link
Member Author

HaoZeke commented Sep 19, 2023

Not required, unrelated error. Tests pass locally.

@HaoZeke HaoZeke closed this Sep 19, 2023
@HaoZeke
Copy link
Member Author

HaoZeke commented Sep 19, 2023

AFAIK the tests are skipped anyway, but this might be more explicit.

@HaoZeke HaoZeke reopened this Sep 19, 2023
@charris
Copy link
Member

charris commented Sep 19, 2023

Should actually be fixed in the next release

Which is the next release?

@HaoZeke
Copy link
Member Author

HaoZeke commented Sep 19, 2023 •
edited
Loading

Should actually be fixed in the next release

Which is the next release?

Was thinking of the next bugfix release, 1.26.1.. I'll likely find time to actually fix the compilation tests later this week hopefully in which case this will be moot :)

@mattip
Copy link
Member

mattip commented Sep 21, 2023

Let's wait for a competing PR to fix the tests instead of this one, hopefully before the 1.26.1 release.

@rgommers
Copy link
Member

AFAIK the tests are skipped anyway, but this might be more explicit.

They're either skipped or working, so isn't this PR just an extra hurdle for later? The wheel builds jobs run the full test suite (see tools/wheels/cibw_test_command.sh) and all tests pass on every platform.

The issue in gh-24750 is mostly resolved, and I think the problem was that meson is now a test dependency for the full test suite but it wasn't installed.

@mattip
Copy link
Member

mattip commented Oct 5, 2023

Closing. If there is more work needed to support python3.12 on 1.26 please reopen.

@mattip mattip closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
05 - Testing component: numpy.f2py
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HaoZeke @charris @mattip @rgommers