Skip to content

MAINT: align test_dispatcher s390x targets with _umath_tests_mtargets #24772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2023
Merged

MAINT: align test_dispatcher s390x targets with _umath_tests_mtargets #24772

merged 1 commit into from
Sep 22, 2023
+2 −1

Conversation

cbouss
Copy link
Contributor

@cbouss cbouss commented Sep 21, 2023

This updates https://github.com/numpy/numpy/blob/main/numpy/core/tests/test_cpu_dispatcher.py#L12 targets matching what is set at https://github.com/numpy/numpy/blob/main/numpy/core/meson.build#L688 (i.e. adding VE and VXE).

This was discovered when testing an s390x build with optimization on.

@charris charris added 03 - Maintenance 09 - Backport-Candidate PRs tagged should be backported labels Sep 21, 2023
@charris charris changed the title align test_dispatcher s390x targets with _umath_tests_mtargets MAINT: align test_dispatcher s390x targets with _umath_tests_mtargets Sep 21, 2023
@seiko2plus seiko2plus merged commit 12ea98b into numpy:main Sep 22, 2023
@seiko2plus
Copy link
Member

Thank you, this fix should resolves #24750

@seiko2plus seiko2plus added the component: SIMD Issues in SIMD (fast instruction sets) code or machinery label Sep 22, 2023
@seiko2plus seiko2plus mentioned this pull request Sep 22, 2023
Closed
@charris charris mentioned this pull request Sep 26, 2023
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Sep 26, 2023
@charris
Copy link
Member

charris commented Sep 26, 2023

@seiko2plus The #24814 backport failed a test on the travis s390x. Might be a problem with the test .

>       assert_equal(test["func"], "func" + highest_sfx)
E       AssertionError: 
E       Items are not equal:
E        ACTUAL: 'func'
E        DESIRED: 'func_VXE'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance component: SIMD Issues in SIMD (fast instruction sets) code or machinery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbouss @seiko2plus @charris