BUG: Fix build on ppc64 when the baseline set to Power9 or higher #24806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e81137 to
431b7dd
Compare
…Half/Double VSX3 instructions by the assembler
This fix addresses two issues:
* Corrects the use of unsupported instructions by the assembler
in half-precision to double-precision conversion.
* Resolves a code error related to variable naming during conversion.
431b7dd to
771beb0
Compare
|
@seiko2plus is this still marked as Draft on purpose? |
I had to test it locally against an assembler that doesn't support VSX3 scalar double-precision conversion. It's ready for review now. |
|
Thanks Sayed. |
charris
added a commit
to charris/numpy
that referenced
this pull request
Nov 11, 2023
Backport of numpy#24806. This backport was already made in numpy#25083, but that didn't make use of the linux_qemu.yml action, so this tweaks it a bit.
charris
added a commit
to charris/numpy
that referenced
this pull request
Nov 11, 2023
Backport of numpy#24806. This backport was already made in numpy#25083, but that didn't make use of the linux_qemu.yml action, so this tweaks it a bit.
charris
added a commit
to charris/numpy
that referenced
this pull request
Nov 11, 2023
Backport of numpy#24806. This backport was already made in numpy#25083, but that didn't make use of the linux_qemu.yml action, so this tweaks it a bit.
charris
added a commit
to charris/numpy
that referenced
this pull request
Nov 11, 2023
Backport of numpy#24806. This backport was already made in numpy#25083, but that didn't make use of the linux_qemu.yml action, so this tweaks it a bit.
|
FWIW: 7a84442 fixes a test failure in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #24789