Skip to content

MAINT: Remove 'a' dtype alias #24854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2023
Merged

MAINT: Remove 'a' dtype alias #24854

merged 2 commits into from
Oct 4, 2023

Conversation

mtsokol
Copy link
Member

@mtsokol mtsokol commented Oct 4, 2023

Hi @rgommers,

In this PR I removed np.dtype("a") alias that is the same as np.dtype(bytes). I found only 10 legacy usages in the GitHub search, would you like to have a migration message here also?

@rgommers
Copy link
Member

rgommers commented Oct 4, 2023

Thanks @mtsokol! Looks like we had some tests that exercised 'a' which now need changing.

@rgommers rgommers added this to the 2.0.0 release milestone Oct 4, 2023
@mtsokol
Copy link
Member Author

mtsokol commented Oct 4, 2023

That's right - fixing them now.

@mtsokol mtsokol force-pushed the remove-a-dtype-alias branch 2 times, most recently from 9829f0f to cdc8c81 Compare October 4, 2023 15:04
@mtsokol mtsokol force-pushed the remove-a-dtype-alias branch from cdc8c81 to 0666e33 Compare October 4, 2023 15:22
rgommers
rgommers approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks happy now, the one CI failure is unrelated. All LGTM, and this was already discussed on the previous PR - so in it goes. Thanks Mateusz

@rgommers rgommers merged commit 01e33cd into numpy:main Oct 4, 2023
@rgommers rgommers added the 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified. label Oct 4, 2023
@mtsokol mtsokol deleted the remove-a-dtype-alias branch October 4, 2023 18:49
@mtsokol mtsokol mentioned this pull request Oct 9, 2023
Closed
@mroeschke mroeschke mentioned this pull request Oct 9, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
03 - Maintenance 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified.
Projects
None yet
Milestone
2.0.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@mtsokol @rgommers