MAINT: Python API cleanup nitpicks #24959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d53b22 to
a95a54c
Compare
16 tasks
a95a54c to
7112699
Compare
ngoldbaum
reviewed
Oct 19, 2023
| from ._version import * | ||
| from .introspect import * | ||
| from numpy._core._multiarray_umath import add_docstring, tracemalloc_domain | ||
| from numpy._core.function_base import add_newdoc | ||
|
|
||
| __all__ = ['emath'] |
There was a problem hiding this comment.
Searching on github I don't find any usages of np.lib.emath. Still, It's been here for a long time and we're still publicly exposing np.emath, so it would be nice to generate a nicer AttributeError with a migration in the __getattr__ for the module.
There was a problem hiding this comment.
Sure! I added a proper error message for np.lib.emath.
7112699 to
9df0469
Compare
9df0469 to
4c0bc26
Compare
|
Thanks @mtsokol! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains last cleanup changes for #23999.
Currently it consists of:
numpy.coreimport sort,np.lib.arrayteratorprivate,np.lib.__all__.