BUG: fix issues with newaxis and linalg.solve in numpy.array_api
#25146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip azp] [skip cirrus] [skip circle]
|
The failure in the OpenSUSE BLAS job is unrelated; I'll have a look at that. |
seberg
reviewed
Nov 14, 2023
| with errstate(call=_raise_linalgerror_singular, invalid='call', | ||
| over='ignore', divide='ignore', under='ignore'): | ||
| r = gufunc(a, b, signature=signature, extobj=extobj) | ||
| with np.errstate(call=_raise_linalgerror_singular, invalid='call', |
There was a problem hiding this comment.
Interesting that the errstate removal did make it? Anyay, LGTM, thanks.
There was a problem hiding this comment.
I think the implementation here was added before this was thoroughly tested in the test suite. Maybe the errstate import was removed and that went unnoticed due to incomplete test coverage.
asmeurer
reviewed
Nov 14, 2023
| @@ -125,7 +125,7 @@ | |||
|
|
|||
| __all__ = ["__array_api_version__"] | |||
|
|
|||
| from ._constants import e, inf, nan, pi | |||
| from ._constants import e, inf, nan, pi, newaxis | |||
|
|
|||
| __all__ += ["e", "inf", "nan", "pi"] | |||
rgommers
added a commit
to rgommers/numpy
that referenced
this pull request
Jan 18, 2024
Follows up on a post-merge comment in numpygh-25146. [skip ci]
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jan 18, 2024
Follows up on a post-merge comment in numpygh-25146. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this wasn't caught before because of gaps in the test coverage (fixed for
linalg.solveand fix ready to merge fornewaxisinarray-api-tests).[skip azp] [skip cirrus] [skip circle]