Skip to content

CI/BLD: fix bash script tests for cibw #25763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 5, 2024
Merged

CI/BLD: fix bash script tests for cibw #25763

merged 5 commits into from
Feb 5, 2024

Conversation

andyfaff
Copy link
Member

@andyfaff andyfaff commented Feb 5, 2024

This PR fixes a several logic tests in bash scripts that are used for building wheels on macOS. If we're on Sonoma we need to be using Accelerate, and the logic tests were falsely installing gfortran (which should be supplied by micromamba) and openblas which meant that that is picked up instead of Accelerate.

Copy link
Member

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small nits, otherwise LGTM.

andyfaff and others added 2 commits February 5, 2024 20:50
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: Matti Picus <matti.picus@gmail.com>
@mattip mattip merged commit 922ef5e into numpy:main Feb 5, 2024
@mattip
Copy link
Member

mattip commented Feb 5, 2024

Thanks @andyfaff

@andyfaff andyfaff deleted the ci branch February 5, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants