BLD: restore 'setup-args=-Duse-ilp64=true' in cibuildwheel [wheel build] #25803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, the test failures look like a case of tolerances being too tight. Why it should manifest now is another question. |
|
Comparing the log file with the failure to a older passing scheduled wheel build (before #25505), I see these differences:
Other than that, the meson configuration and build looks identical, down to the warnings in the templated function |
rgommers
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
This fixes the problem:
# Accelerate build:
Run-time dependency accelerate found: YES
Message: BLAS symbol suffix: $NEWLAPACK$ILP64
# OpenBLAS build
Run-time dependency scipy-openblas found: YES 0.3.26
Message: BLAS symbol suffix: 64_
The TestFFT1D.test_identity_long_short_reversed[longdouble] is unrelated, and almost certainly due to gh-25711; wheel builds probably weren't tested there. So let's open a new issue for that, and get this fix in.
Thanks Matti.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes line changed in #25505
Motivated by this comment, cc @rgommers