BUG: avoid incorrect type punning in NpyString_acquire_allocators #25958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sanitizers CI passed, merging this should unbreak it on main. |
|
Thanks Nathan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25957. It may also fix the hangs on sanitizer CI too, we'll have to see.
I think merging #25943 made this more visible, but it was always buggy to do this.
The issue is that
descrsdoesn't necessarily contain onlyPyArray_StringDTypeObjectinstances, so it's incorrect to cast (say) a LONG descriptor toPyArray_StringDTypeObjectin the following line.The fix is to check for this case and skip the cast if the descriptor we want to compare with isn't a stringdtype descriptor.