Skip to content

CI: fix wheel tags for Cirrus macOS arm64 #25965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Mar 8, 2024

As can be seen from for example this log, there was a small hiccup with gh-25945 and now wheels built with OpenBLAS are tagged as 14_0 rather than 11_0. So simplify the logic to ensure that these wheels are tagged for 11.0

Note that this also overwrote the 14_0 nightlies on https://anaconda.org/scientific-python-nightly-wheels/numpy/files, so I'll rebuild those.

[skip actions] [skip circle] [skip azp]
@rgommers rgommers added this to the 2.0.0 release milestone Mar 8, 2024
@rgommers rgommers requested a review from andyfaff March 8, 2024 10:09
@rgommers rgommers changed the title CI: fix wheel tags for Cirrus macOS arm64 [wheel build] CI: fix wheel tags for Cirrus macOS arm64 Mar 8, 2024
@rgommers
Copy link
Member Author

rgommers commented Mar 8, 2024

Triggered the build to see that this is now correct:

MACOSX_DEPLOYMENT_TARGET='11.0'
...
Successfully built numpy-2.0.0.dev0-cp311-cp311-macosx_11_0_arm64.whl

I'll just merge this and retrigger the wheel builds - that's the same as the jobs running on this PR, except that the wheels will be uploaded at the end.

@rgommers rgommers merged commit b0d317b into numpy:main Mar 8, 2024
@rgommers rgommers deleted the fix-cirrus-wheel-tag branch March 8, 2024 10:14
@andyfaff
Copy link
Member

andyfaff commented Mar 8, 2024

Let me know if I need to clear anything up.

@rgommers
Copy link
Member Author

rgommers commented Mar 8, 2024

Thanks. Looks like it's all good now - new wheels are up.

@rgommers
Copy link
Member Author

rgommers commented Mar 8, 2024

Ah, now I see why it broke:

Auto-upgraded from ghcr.io/cirruslabs/macos-monterey-xcode:14 to ghcr.io/cirruslabs/macos-sonoma-xcode:latest

The logic depended on the macOS version, and this upgrade threw it off so the x86-64 builds switched to 14_0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants