Scalarfromobject bug #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CPython, boolean is a subtype of integer, so the PyInt_Check was catching booleans as well.
|
Seems obvious, pushed. |
mattip
referenced
this pull request
in mattip/numpy
Mar 20, 2019
Clarify that the internal generator is closed on [low, high-1] even though the external interface is open [low, high) closes #26
bashtage
referenced
this pull request
in bashtage/numpy
May 23, 2019
Clarify that the internal generator is closed on [low, high-1] even though the external interface is open [low, high) closes #26
fangerer
pushed a commit
to hpyproject/numpy-hpy
that referenced
this pull request
Jul 7, 2022
Merge in ~STEPAN.SINDELAR_ORACLE.COM/numpy-hpy from ss/PyArray_InitializeCasts2 to labs-hpy-port * commit '6eb541713b7243b66452826de33e8887d14e023c': Port intern_strings set_matmul_flags PyArray_InitializeDatetimeCasts PyArray_InitializeObjectToObjectCast PyArray_InitializeVoidToVoidCast PyArray_InitializeStringCasts Partial port of PyArray_InitializeStringCasts
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vqadd_s8
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't look like there's a way to test this in Python, but the fix is pretty trivial.