MAINT: handle NPY_ALLOW_THREADS and related build option better
#26016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option to disable threading in CPython was removed a long time ago (see cpython#3385); `WITH_THREAD` was kept defined for backwards compatibility, but can never change - so best to remove checking for it. The docs still mentioned the old `NPY_NOSMP` environment variable, support for which was removed with the move to Meson. Instead, there is a `disable-threading` build option, so document that.
|
Thanks Ralf. |
NPY_ALLOW_THREADS and related build option betterNPY_ALLOW_THREADS and related build option better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option to disable threading in CPython was removed a long time ago (see python/cpython#3385);
WITH_THREADwas kept defined for backwards compatibility, but can never change - so best to remove checking for it.The docs still mentioned the old
NPY_NOSMPenvironment variable, support for which was removed with the move to Meson. Instead, there is adisable-threadingbuild option, so document that.