Skip to content

MAINT: Escalate import warning to an import error #26167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2024
Merged

MAINT: Escalate import warning to an import error #26167

merged 3 commits into from
Mar 29, 2024

Conversation

charris
Copy link
Member

@charris charris commented Mar 29, 2024

Backport of #26149.

@charris charris added 03 - Maintenance 08 - Backport Used to tag backport PRs labels Mar 29, 2024
@charris charris added this to the 2.0.0 release milestone Mar 29, 2024
rgommers
rgommers approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the lint error seems optional here. Okay to move ahead if you prefer.

@charris
Copy link
Member Author

charris commented Mar 29, 2024

I just ignore lint on occasion, this is one of those occasions.

@charris charris merged commit 4c65fd2 into numpy:maintenance/2.0.x Mar 29, 2024
57 of 61 checks passed
@charris charris deleted the backport-26149 branch March 29, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
03 - Maintenance 08 - Backport Used to tag backport PRs
Projects
None yet
Milestone
2.0.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@charris @rgommers @seberg