MNT: use reproducible RNG sequences in benchmarks #26638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkern
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
In the spirit of avoiding common seeds wherever possible for didactic reasons (and avoiding mostly-negligible but still niggling bias when reusing streams for different purposes), I've taken the liberty of assigning different 31-bit seeds.
Other than that (and it's truly optional), LGTM!
Co-authored-by: Robert Kern <robert.kern@gmail.com>
Co-authored-by: Robert Kern <robert.kern@gmail.com>
Co-authored-by: Robert Kern <robert.kern@gmail.com>
|
Thanks Nathan. |
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These three benchmarks aren't using seeded RNG sequences so the test data is not consistent from run to run. Using a seeded
RandomStateshould fix that for these benchmarks.