Skip to content

CI: build and upload free-threaded nightly wheels for macOS #26664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ngoldbaum
Copy link
Member

[skip azp][skip circle][skip cirrus]

Tested on my fork so hopefully this builds on the first try.

@ngoldbaum ngoldbaum added the 39 - free-threading PRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703) label Jun 11, 2024
@ngoldbaum
Copy link
Member Author

This also takes advantage of the new cython nightly wheel to avoid building cython from source.

@rgommers rgommers changed the title MNT: build and upload mac free-threaded nightlies [wheel build] CI: build and upload free-threaded nightly wheels for macOS Jun 11, 2024
@rgommers rgommers self-requested a review June 11, 2024 19:37
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nathan! Everything looks right here, so let's give this a go.

I was confused for a moment why there are 3 rather than 4 wheels - but it's because the macOS arm64 OpenBLAS flavor for macOS <14.0 is still built on CirrusCI. We don't want to deal with that, so this looks good as is. We could conceivably even support only macOS >=14 here, however this mirrors what we do in wheels.yml so as long as we're not short of CI time this is nice.

@rgommers rgommers merged commit aaf762b into numpy:main Jun 11, 2024
97 checks passed
@rgommers rgommers added this to the 2.1.0 release milestone Jun 11, 2024
@ngoldbaum
Copy link
Member Author

Thanks for clarifying, I was confused why openblas on arm64 wasn't a thing in this config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 - Maintenance 39 - free-threading PRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants