Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH, DOC: Add support for interactive examples for NumPy with
jupyterlite-sphinx
#26745New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH, DOC: Add support for interactive examples for NumPy with
jupyterlite-sphinx
#26745Changes from all commits
cefa572
5d15ea7
8d0114c
e1e8c4f
e87644a
7e0b2ec
74146d4
82811be
078be70
9537956
c868c37
9920a4f
5a7ff94
d3ccdd0
b2e3f68
80bc774
65abdd9
bb03ae3
484fe56
6b416ae
a20fde9
0c7908f
61791d8
8681816
0547d8f
5e90b82
7b18a43
4924735
b31f5f2
060118d
8785bb9
5f98a64
0885ae2
bf2c6f3
0bdb460
f1a15cc
80a50a9
30f9792
905279a
7b000dd
7f8f711
458a122
6565c9d
36b5e89
e750b49
a53fe4c
f484c60
cc5598b
7a321d3
3df390e
d69365d
ef3f14b
901c04e
d818f8c
bc78dd5
0713994
369e27d
6b59b9c
e7972a5
493b9a8
8e7d769
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For another time, do you believe it would be worth having a pre-comit to format the css in the numpy repo ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so! I couldn't find many within the
pre-commit
framework that seem to be regularly maintained, but Node.js-based tools exist, such as https://github.com/stylelint/stylelint that one can use withnpm
, or betternpx
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier
can lint HTML and CSS files. I think I can add it after this PR if this is still needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer no pre-commit or new linting work as a result of this PR; lots of effort and bikeshedding involved for not enough gain.