BUG: fix download link in setup.py (which is shown on PyPi). #2707
Conversation
Closes Trac ticket 2243.
| MAJOR = 1 | ||
| MINOR = 8 | ||
| MAJOR = 1 | ||
| MINOR = 8 |
There was a problem hiding this comment.
This needs to be changed to 7 for the backport, right?
There was a problem hiding this comment.
Indeed. I can fix that and backport this myself; Ondrej is busy IIRC.
There was a problem hiding this comment.
You might as well commit it then. I checked the URL and it looks good to me. I assume PyPi can figure out the versions from there?
There was a problem hiding this comment.
Guess so, but I'll check when I upload a fix for 1.6.2 to PyPi.
There was a problem hiding this comment.
Eh, sorry, replied too fast. Your question doesn't parse. PyPi doesn't figure out versions. Do you mean pip?
There was a problem hiding this comment.
On Fri, Nov 9, 2012 at 9:56 AM, Ralf Gommers notifications@github.comwrote:
In setup.py:
LICENSE = 'BSD'
CLASSIFIERS = filter(None, CLASSIFIERS.split('\n'))
AUTHOR = "Travis E. Oliphant, et.al."
AUTHOR_EMAIL = "oliphant@enthought.com"
PLATFORMS = ["Windows", "Linux", "Solaris", "Mac OS-X", "Unix"]
-MAJOR = 1
-MINOR = 8
+MAJOR = 1
+MINOR = 8Eh, sorry, replied too fast. Your question doesn't parse. PyPi doesn't
figure out versions. Do you mean pip?
Actually, I don't know what I'm talking about ;) I just used your PR
comment.
|
@rgommers, can you do this? I don't want to make a mistake while backporting this. |
BUG: fix download link in setup.py (which is shown on PyPi).
|
OK, merging this. Will backport too. |
|
Backported in 98ca13d. |
|
BTW, that should also probably be "et al."
|
|
"that" = ? |
|
Sorry, "Travis Oliphant, et. al" -> "Travis Oliphant et al." in the AUTHOR field. |
|
Yeah, it's been et al for a while. New PR? |
|
My most glorious PR yet: #2744 :-) |
|
Thanks! |
Closes Trac ticket 2243.
@certik: should be backported to 1.7.x
I'll upload a new PKGINFO to PyPi for 1.6.2 when this is merged.