BUG: weighted quantile for some zero weights #27549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The added test fails as expected, see, e.g., CI |
|
Looks good, but to make sure: Do we have tests for the 0 weights being in a position other than the start? I don't think it is particularly interesting with the current code, but maybe good to add anyway. |
Yes, e.g. in But this is not the main point. |
Yes, I realize. But seemed good to cover out of principle. LGTM, then let's put it in, thanks. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Oct 15, 2024
This PR fixed weighted quantiles (and percentiles) for a corner case: * at least one weight is zero * q=0 (0-quantile equals minimum) Then: ``` np.quantile(np.arange(3), 0, weights=[0, 0, 1], method="inverted_cdf") ``` should return 2, the minimum when neglecting zero weight values. Current main returns 0.
charris
added a commit
that referenced
this pull request
Oct 15, 2024
BUG: weighted quantile for some zero weights (#27549)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed weighted quantiles (and percentiles) for a corner case:
q=0(0-quantile equals minimum)Then:
should return
2, the minimum when neglecting zero weight values. Current main returns0.