Skip to content

DEV: Update spin usage in NumPy (prototype) #27606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

czgdp1807
Copy link
Member

@charris charris changed the title Update spin usage in NumPy (prototype) ENH: Update spin usage in NumPy (prototype) Oct 21, 2024
@mattip
Copy link
Member

mattip commented Oct 21, 2024

Without further comments specific to NumPy, I understand we should wait for resolution of the related scipy/scipy and scientific-python/spin PRs to be resolved before looking at this one. Should we mark it as "draft" until then?

@ngoldbaum
Copy link
Member

scientific-python/spin#242 and scientific-python/spin#241 are also related. What I'd really like is if we could simply delegate to upstream, adding the one argument we want to add, without needing to update our spin build command every time something changes in spin.

@charris
Copy link
Member

charris commented Oct 21, 2024

Note that spin should not be used to generate the changelog and update the notes, those are both part of the release preparation, not the document generation.

@rgommers
Copy link
Member

This seems reasonable once the linked spin PR lands, but it doesn't do anything extra yet, it just adds the support code to be able to pass arguments to meson compile and meson install. So I'd put this on hold until it's actionable, and then add some new feature that uses that added flexibility.

Note that spin should not be used to generate the changelog and update the notes, those are both part of the release preparation, not the document generation.

@charris spin is a UX for development tasks (and that can/does include recurring release tasks), and it already has spin changelog and spin notes tasks, so I'm not sure what your comment is referring to. There's nothing in this PR that changes anything here.

@rgommers rgommers marked this pull request as draft October 23, 2024 08:33
@rgommers rgommers changed the title ENH: Update spin usage in NumPy (prototype) DEV: Update spin usage in NumPy (prototype) Oct 23, 2024
@czgdp1807
Copy link
Member Author

czgdp1807 commented Oct 23, 2024

Closing this PR. This change should be inside spin and not here. I will give some context shortly. Sorry for the noise.

@czgdp1807 czgdp1807 closed this Oct 23, 2024
@czgdp1807
Copy link
Member Author

Regarding context please see my explanation in scientific-python/spin#238 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants