-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
CI: Set up free-threaded CI using quansight-labs/setup-python #27707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[skip azp] [skip cirrus] [skip circleci]
I know chuck already approved, but I just pushed a fixup so the MacOS accelerate tests have shorter names so the python version is still visible in the PR summary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ngoldbaum. This does add two extra jobs; okay for now but if that becomes too much, we can prune one of the two x86-64 ones.
Since you tweaked job names, I pushed one more tiny commit to remove a not-so-useful (meson)
from the job name.
Can you add a comment somewhere to make it easier to check back periodically to see when the upstream action adds free-threading versions? I understand the need for the fork but fear it might bitrot over time |
I think dependabot will keep it updated and hopefully the release note with the update will have that information. We will see. |
Thanks Nathan. |
We've forked
actions/setup-python
to enable installing free-threaded python on more platforms. See Quansight-Labs/free-threaded-compatibility#107 for context.This makes the MacOS and Linux tests use the forked version of
setup-python
to enable integrating the free-threaded tests with the rest of the CI configuration.This creates two new CI jobs that run against every PR for MacOS free-threaded using builds on intel and ARM CPUs. The linux CI job isn't new, but now it's integrated better with the smoke tests. I also took the opportunity to drop
3.13-dev
from the build matrix.Updating Windows CI is blocked on a
spin
release, see scientific-python/spin#241.Supersedes #27581.