TYP: Annotate __setitem__, __contains__ and __iter__ of ndarray
#27755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Joren. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__setitem__and__contains__methods ofndarraywere actually missing, which was causing errors in 3rd party libraries that ranpyright --verifytypes.For
__iter__the return type was annotated asAny. It will now returns an iterator of scalars or arrays, depending on its shape (1-d vs. >1-d).The changes in
__getitem__are the result of a newly extracted type alias for the index type, as to avoid duplication with the added annotations for__setitem__.