WIP,CI: Update Cygwin CI Python to 3.12 #28107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DWesl
commented
Jan 6, 2025
| @@ -16,7 +16,7 @@ jobs: | |||
| cygwin_build_test: | |||
| runs-on: windows-latest | |||
| # To enable this workflow on a fork, comment out: | |||
| if: github.repository == 'numpy/numpy' | |||
| # if: github.repository == 'numpy/numpy' | |||
There was a problem hiding this comment.
Suggested change
| # if: github.repository == 'numpy/numpy' | |
| if: github.repository == 'numpy/numpy' |
Accept this suggestion before merging
There was a problem hiding this comment.
I thought I was making this PR on another repository. This should probably be marked as draft until then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cygwin CI was dropped when support for the latest python version on Cygwin was dropped (#26247). This attempts to add in the new 3.12 test.
The 3.9 test had some shims in to avoid hangs in the old test version of 3.9. Nobody's figured out where this is happening, so those might still be in (mostly in pip runs).