BUG: handle case when StringDType na_object is nan in float to string cast #28228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately I don't think this can be easily backported without re-doing the PR inside the macro in the |
mhvk
approved these changes
Jan 26, 2025
| "to string cast"); | ||
| goto fail; | ||
| } | ||
| goto next_step; |
There was a problem hiding this comment.
I'd tend to just move the old code into an else { clause and thus avoid the goto here.
There was a problem hiding this comment.
But then you never store the scalar if the scalar value isn't the na_object, unless you add an else clause for the if (na_object) block that duplicates the code storing the scalar value. IMO the goto is better since there's less copy/pasted code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28157.