-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Pull request #445, rebased #2840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fixes an issue with ndindex shape tuple recognition, and an issue in the nditer where scalar input did not produce an empty index tuple. To be able to fix nditer, an extra flag has been added: NPY_ITFLAG_SCALAR and a new function NpyIter_IsScalar has been added to the nditer API. Also a few tests have been added to make sure the ndindex behaves as intended.
All tests fail with the error:
So this needs to be fixed. |
This looks like a straight-up bug in On Sun, Dec 16, 2012 at 10:13 PM, Ondřej Čertík notifications@github.comwrote:
|
@87, would you have time to fix that? |
@certik Already committed? The removal of |
Ok, cool. I am closing this pull request. |
My bad, first NpyIter_IsScalar was added, then it was removed again. So it is still gone ;) |
@seberg Does your work cover this? If so, just comment and close. |
Yes, this should be superceded by gh-3104, so closing. |
I just rebased #445 on top of the latest master and resolved the conflicts.