BUG: bugfix for #28589 (quantile should error when weights are all zeros) #28594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eights are all zeros numpy#28589 Previously, np.quantile with all weights set to zero returned the first sample. This is fixed now via adding an explicit check that raises a ValueError when all weights are zero, preventing division by zero in the CDF. - Added the weight check in `_quantile` (line 4874 ff) to detect all-zero weights and raise an error. - Added a test in `test_function_base.py` to verify this behavior. - Added a second test to ensure existing quantile functionality remains unchanged. This should close numpy#28589
| result = np.quantile(arr, quantile, weights=weights, method='inverted_cdf') | ||
| expected = 2.5 | ||
|
|
||
| assert np.isclose(result, expected) |
There was a problem hiding this comment.
Hopefully this part of the diff isn't really needed--presumably we have sufficient testing that if you broke the numerical behavior of quantile an existing test would fail.
That said, this test actually does fail--maybe there is a problem with the test design?
There was a problem hiding this comment.
As an aside, assert_allclose() is generally preferable in testing--it tends to give better feedback when something fails, etc.
| weights = np.array([0, 0, 0, 0]) | ||
|
|
||
| with pytest.raises(ValueError, match="All weights are zero, cannot compute quantile."): | ||
| np.quantile(arr, quantile, weights=weights, method='inverted_cdf') |
There was a problem hiding this comment.
Note for other NumPy devs--this/this PR is very similar to gh-28597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the following BUG: quantile should error when weights are all zeros #28589
Previously, np.quantile with all weights set to zero returned the first sample. This is fixed now via adding an explicit check that raises a ValueError when all weights are zero, preventing division by zero in the CDF.
_quantile(line 4874 ff) to detect all-zero weights and raise an error.test_function_base.pyto verify this behavior.This should close #28589