STY: Partially apply ruff/pycodestyle rules (E) #28775
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
4215dac to
3186edb
Compare
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
The problem is with reformatting multidimensional array data, the result is just awful. |
Yea I agree. But in this case it's a 1d array that's arbitrarily split over two lines. BTW, enforcing |
|
I unwrapped the split line as it fits the new line-length limit of 88 characters. By the way, would you accept a PR that runs |
This comment has been minimized.
This comment has been minimized.
Only if it's possible to enforce a different max-line-length for |
|
Rebase needed. |
Multiple spaces after comma Do not apply this rule to tabular data, tables must remain aligned.
Unexpected spaces around keyword / parameter equals For now, do not modify large and consistent code blocks that use spaces on purpose, mostly when the default values are arrays.
Block comment should start with `# ` For now, keep commented out code as is.
Too many leading `#` before block comment For now, do not modify titles.
Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>
Unwrap the array arbitrarily split over two lines, as it fits the new default line-length limit of 88 characters. Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>
|
FYI, it turned out that the mypy_primer issue was unrelated after all: hauntsaninja/mypy_primer#161 |
|
Thanks Dimitri :) |
Partially apply some ignored
Erules.These rules cannot be applied blindly. For example, tabular data requires extra spaces to remain aligned.
Not sure yet how to enable these rules. For example, exclude files that contain tabular data?