Fix poisson deviate for expected values ~> LONG_MAX #29
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we can't support a complete poissonian disribution for values on the order and greater than LONG_MAX, we simply return the expected value for these very large expected values.
|
What if lambda itself exceeds the maximum value than can be held in a long? Maybe an error needs to be raised somewhere, although I don't see how, there is no error return available. There is a small logic error also. I think this patch needs a bit of work still. |
|
I've fixed the logic error in and added in error checking (inside mtrand.pyx). I'll issue a new pull request... |
fangerer
added a commit
to hpyproject/numpy-hpy
that referenced
this pull request
Jul 7, 2022
…iscoverDTypeAndShape Merge in ~STEPAN.SINDELAR_ORACLE.COM/numpy-hpy from fa/PyArray_Pack to labs-hpy-port * commit 'b2c1d7edcc1242e1397ae292c784c2a791bc4fa2': Fix some warnings due to legacy function signature Migrate function signature PyArray_SetItemFunc Migrate PyArray_DiscoverDTypeAndShape Use HPyDict_GetItem to ignore error context Migrate PyArray_Pack
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
test: Use self-maintained GNU toolchain binary
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch causes rk_poisson to simply return the mean value of the Poissonian when the distribution cannot be supported by the high-order bits of the long integer type. This patch simply checks whether the mean value is less than LONG_MAX - 10 * sqrt(LONG_MAX) before actually generating a random deviate. This ensures that at least 20*sigma (sigma=sqrt(mean value)) of width for the distribution--this should be plenty of width.